Fix dell-replication-controller-config reconcile reset issue #755
Conversation
nitesh3108
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
chimanjain,
coulof,
Deepak-Ghivari,
gallacher,
gilltaran,
harishp8889,
HarishH-DELL,
JacobGros,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
meggm,
mgandharva,
mjsdell,
Prabhu-Dell,
rajendraindukuri,
rajkumar-palani,
shefali-malhotra,
panigs7,
tdawe and
shaynafinocchiaro
as code owners
nitesh3108
requested review from
atye,
sharmilarama and
shanmydell
as code owners
nitesh3108
force-pushed
the
replication-test
branch
from
530ed1c
to
348e216
Compare
| @@ -116,6 +116,7 @@ func getDaemonSetStatus(ctx context.Context, instance *csmv1.ContainerStorageMod | |||
| } | |||
|
|
|||
| for _, cluster := range clusterClients { | |||
| totalRunning = 0 | |||
There was a problem hiding this comment.
What does this totalRunning=0 do? Were we not resetting the count on each iteration of this for loop and needed to be? It doesn't seem related to other code changes in this PR, so it could just be an unrelated fix.
|
All checks pass (though I don't know how to fully interpret the However, Operator E2E tests have not been run on an image generated by these code changes, and I don't think such an E2E test will pass given the |
|
|
* feature/pmax-minimal-sample-e2e * indentation fix * yamllint fixes * quay.io updates and some cleanup * yamllint fixes * add replica count * add csipowermax-reverseproxy * yamllint fixes * added replication scenarios for powermax --------- Co-authored-by: Harish P <[email protected]>
* Add Ut for HasModuleComponent & AddModuleComponent * Refactor code and add UT for LoadDefaultComponents * Refactor code and add more test cases * Refactor code and add more test cases * Fix error reported by golangci-lint
* Removed latest version fetching through a function * updated replication controller image to quayio * quay image updates * removed dead code
… nginx image (#747) * update nginxinc/nginx-unprivileged image * add coordination.k8s.io access for observability * bump trivy-action
* point latest images to quay.io * point latest images to quay.io-tests folder * point latest images to quay.io-tests folder --------- Co-authored-by: Harish P <[email protected]> Co-authored-by: Harish P <[email protected]>
* E2E tests for PMax driver in minimal manifest file Auth v1 Signed-off-by: meghana_gm <[email protected]> * add powermax auth v2 testfile * remove line --------- Signed-off-by: meghana_gm <[email protected]> Co-authored-by: Aaron Tye <[email protected]>
ChristianAtDell
force-pushed
the
replication-test
branch
from
4832f21
to
79db65b
Compare
|
Effort has been cherry-picked to PR #760 because of a failure to sign a merge commit and a rebase error. |
Closing due to rebase-error.
See PR #760
Description
Configmap (dell-replication-controller-config) is installed as part of the controller.yaml with empty values for clusterId and targets. Once we inject the cluster details using repctl cluster inject, the configmap is updated with the correct information. However, during the csm-operator reconcile loop, the configmap is getting reset, resulting in resetting the configmap.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration